[
https://issues.apache.org/jira/browse/HDFS-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309656#comment-14309656
]
Brahma Reddy Battula commented on HDFS-7732:
--------------------------------------------
Thanks [~ajisakaa] for filing this issue..
> Fix the order of the parameters in DFSConfigKeys
> ------------------------------------------------
>
> Key: HDFS-7732
> URL: https://issues.apache.org/jira/browse/HDFS-7732
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Priority: Trivial
> Attachments: HDFS-7732.patch
>
>
> In DFSConfigKeys.java, there are some parameters between
> {{DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY}} and
> {{DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT}}.
> {code}
> public static final String DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY =
> "dfs.client.read.shortcircuit.buffer.size";
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_KEY =
> "dfs.client.read.shortcircuit.streams.cache.size";
> public static final int
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_DEFAULT = 256;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_KEY =
> "dfs.client.read.shortcircuit.streams.cache.expiry.ms";
> public static final long
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_DEFAULT = 5 * 60 * 1000;
> public static final int DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT =
> 1024 * 1024;
> {code}
> The order should be corrected as
> {code}
> public static final String DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY =
> "dfs.client.read.shortcircuit.buffer.size";
> public static final int DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT =
> 1024 * 1024;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_KEY =
> "dfs.client.read.shortcircuit.streams.cache.size";
> public static final int
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_DEFAULT = 256;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_KEY =
> "dfs.client.read.shortcircuit.streams.cache.expiry.ms";
> public static final long
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_DEFAULT = 5 * 60 * 1000;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
