[
https://issues.apache.org/jira/browse/HDFS-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310050#comment-14310050
]
Hadoop QA commented on HDFS-7732:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697087/HDFS-7732.patch
against trunk revision 1425e3d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1156 javac
compiler warnings (more than the trunk's current 154 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
48 warning messages.
See
https://builds.apache.org/job/PreCommit-HDFS-Build/9462//artifact/patchprocess/diffJavadocWarnings.txt
for details.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.crypto.TestHdfsCryptoStreams
The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9462//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/9462//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9462//console
This message is automatically generated.
> Fix the order of the parameters in DFSConfigKeys
> ------------------------------------------------
>
> Key: HDFS-7732
> URL: https://issues.apache.org/jira/browse/HDFS-7732
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-7732.patch
>
>
> In DFSConfigKeys.java, there are some parameters between
> {{DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY}} and
> {{DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT}}.
> {code}
> public static final String DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY =
> "dfs.client.read.shortcircuit.buffer.size";
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_KEY =
> "dfs.client.read.shortcircuit.streams.cache.size";
> public static final int
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_DEFAULT = 256;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_KEY =
> "dfs.client.read.shortcircuit.streams.cache.expiry.ms";
> public static final long
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_DEFAULT = 5 * 60 * 1000;
> public static final int DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT =
> 1024 * 1024;
> {code}
> The order should be corrected as
> {code}
> public static final String DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_KEY =
> "dfs.client.read.shortcircuit.buffer.size";
> public static final int DFS_CLIENT_READ_SHORTCIRCUIT_BUFFER_SIZE_DEFAULT =
> 1024 * 1024;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_KEY =
> "dfs.client.read.shortcircuit.streams.cache.size";
> public static final int
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_SIZE_DEFAULT = 256;
> public static final String
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_KEY =
> "dfs.client.read.shortcircuit.streams.cache.expiry.ms";
> public static final long
> DFS_CLIENT_READ_SHORTCIRCUIT_STREAMS_CACHE_EXPIRY_MS_DEFAULT = 5 * 60 * 1000;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
