[ 
https://issues.apache.org/jira/browse/HDFS-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309919#comment-14309919
 ] 

Tsz Wo Nicholas Sze commented on HDFS-6133:
-------------------------------------------

- PBHelper.convert(..) only adds one FALSE when targetPinnings == null.  Should 
we add n FALSEs, where n = targetPinnings.length?
- Remove "use sticky bit" from the javadoc below since an implementation may 
not use sticky bit.
{code}
//FsDatasetSpi
+  /**
+   * Use sticky bit to pin the block
+   */
+  public void setPinning(ExtendedBlock block) throws IOException;
{code}
- FileUtil currently does not support sticky bit so that using LocalFileSystem 
is correct.  Is there a way to add support to stick bit in FileUtil?
- There are some tab characters.  Please replace them by spaces.

Thanks for working hard on this!


> Make Balancer support exclude specified path
> --------------------------------------------
>
>                 Key: HDFS-6133
>                 URL: https://issues.apache.org/jira/browse/HDFS-6133
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer & mover, namenode
>            Reporter: zhaoyunjiong
>            Assignee: zhaoyunjiong
>         Attachments: HDFS-6133-1.patch, HDFS-6133-2.patch, HDFS-6133-3.patch, 
> HDFS-6133-4.patch, HDFS-6133-5.patch, HDFS-6133-6.patch, HDFS-6133-7.patch, 
> HDFS-6133-8.patch, HDFS-6133.patch
>
>
> Currently, run Balancer will destroying Regionserver's data locality.
> If getBlocks could exclude blocks belongs to files which have specific path 
> prefix, like "/hbase", then we can run Balancer without destroying 
> Regionserver's data locality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to