[ 
https://issues.apache.org/jira/browse/HDFS-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313116#comment-14313116
 ] 

Tsz Wo Nicholas Sze commented on HDFS-6133:
-------------------------------------------

> I guess using existence of a second file is easier to be compatible across 
> different platforms (though sticky bit has the advantage of storing the info 
> at the same file).

If using a different file, we need to delete it when deleting the block.  How 
about using the execute bit?

Some comments on the latest patch:
- The new pinning conf property should be in datanode.  We cannot trust clients 
setting the conf correctly.  How about calling it 
"dfs.datanode.block-pinning.enabled"?  When it is disabled, 
FsDatasetImpl.getPinning always return false and setPinning is an no-op.

- We should have some javadoc for FsDatasetSpi.setPinning.  How about the 
following?
{code}
  /**
   * Set a block to be pinned on this datanode so that it cannot be moved
   * by Balancer/Mover.
   *
   * It is a no-op when dfs.datanode.block-pinning.enabled is set to false.
   */
  public void setPinning(ExtendedBlock block) throws IOException;
{code}

> Make Balancer support exclude specified path
> --------------------------------------------
>
>                 Key: HDFS-6133
>                 URL: https://issues.apache.org/jira/browse/HDFS-6133
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer & mover, namenode
>            Reporter: zhaoyunjiong
>            Assignee: zhaoyunjiong
>         Attachments: HDFS-6133-1.patch, HDFS-6133-2.patch, HDFS-6133-3.patch, 
> HDFS-6133-4.patch, HDFS-6133-5.patch, HDFS-6133-6.patch, HDFS-6133-7.patch, 
> HDFS-6133-8.patch, HDFS-6133-9.patch, HDFS-6133.patch
>
>
> Currently, run Balancer will destroying Regionserver's data locality.
> If getBlocks could exclude blocks belongs to files which have specific path 
> prefix, like "/hbase", then we can run Balancer without destroying 
> Regionserver's data locality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to