[ 
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315082#comment-14315082
 ] 

Andrew Wang commented on HDFS-7411:
-----------------------------------

bq. Is it the intended behavior?

Isn't it better that we can quickly mark all these nodes as decommissioned, 
rather than waiting minutes or hours? I don't see why an admin would prefer 
these nodes to stay decom-in-progress for hours. If anything, I hear admins 
complaining about decom being too slow, never the opposite.

bq. Thanks for signing it up. What if you are unavailable later on? What if 
there is a bug you don't know how to fix?

Well, Colin and Ming also reviewed this, so there are two more people who also 
can help maintain. I can't comment on a hypothetical "bug you don't know how to 
fix". Really these statements can be made about any patch.

Do you have specific requirements around additional testing? Or comments about 
my proposals?

> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
>                 Key: HDFS-7411
>                 URL: https://issues.apache.org/jira/browse/HDFS-7411
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, 
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch, 
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch, 
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to 
> DecommissionManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to