[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315201#comment-14315201
]
Chris Douglas commented on HDFS-7411:
-------------------------------------
If the new code were to implement a switch for the current semantics (but not
the existing code), would that satisfy your reservations? A workaround for
unforeseen flaws that falls back to the node-based algorithm is prudent, but
the multi-stage refactor adds more generality to the code that is probably
required. Per your comment, would you want the algorithm to stop when _either_
the max #blocks or max #nodes have been checked? {{numNodesChecked}} is kept
around for metrics anyway; it looks like it could be straightforward to add
this (Andrew, please correct this if it's mistaken)
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
