[
https://issues.apache.org/jira/browse/HDFS-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315254#comment-14315254
]
Arpit Agarwal commented on HDFS-7757:
-------------------------------------
Yes that is fine. Also I think we can eliminate the messages altogether (not
logging even a warning). Quota Violation on one more directories does not
affect the functioning of HDFS in any way.
Also logging this error on image load is kind of arbitrary. If the NameNode is
not restarted for weeks then the administrator will never see this condition.
We could extend fsck or web ui to show directories in this state.
> Misleading error messages in FSImage.java
> -----------------------------------------
>
> Key: HDFS-7757
> URL: https://issues.apache.org/jira/browse/HDFS-7757
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Arpit Agarwal
> Assignee: Brahma Reddy Battula
>
> If a quota violation is detected while loading an image, the NameNode logs
> scary error messages indicating a bug. However the quota violation state is
> very easy to get into e.g.
> # Copy a 2MB file to a directory.
> # Set a disk space quota of 1MB on the directory. We are in quota violation
> state now.
> We should reword the error messages, ideally making them warnings and
> suggesting the administrator needs to fix the quotas:
> Relevant code:
> {code}
> LOG.error("BUG: Diskspace quota violation in image for "
> + dir.getFullPathName()
> + " quota = " + dsQuota + " < consumed = " + diskspace);
> ...
> LOG.error("BUG Disk quota by storage type violation in image for "
> + dir.getFullPathName()
> + " type = " + t.toString() + " quota = "
> + typeQuota + " < consumed " + typeSpace);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
