[
https://issues.apache.org/jira/browse/HDFS-7757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344298#comment-14344298
]
Hadoop QA commented on HDFS-7757:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701996/HDFS-7757-002.patch
against trunk revision ca1c00b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9700//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9700//console
This message is automatically generated.
> Misleading error messages in FSImage.java
> -----------------------------------------
>
> Key: HDFS-7757
> URL: https://issues.apache.org/jira/browse/HDFS-7757
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.6.0
> Reporter: Arpit Agarwal
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-7757-002.patch, HDFS-7757.patch
>
>
> If a quota violation is detected while loading an image, the NameNode logs
> scary error messages indicating a bug. However the quota violation state is
> very easy to get into e.g.
> # Copy a 2MB file to a directory.
> # Set a disk space quota of 1MB on the directory. We are in quota violation
> state now.
> We should reword the error messages, ideally making them warnings and
> suggesting the administrator needs to fix the quotas:
> Relevant code:
> {code}
> LOG.error("BUG: Diskspace quota violation in image for "
> + dir.getFullPathName()
> + " quota = " + dsQuota + " < consumed = " + diskspace);
> ...
> LOG.error("BUG Disk quota by storage type violation in image for "
> + dir.getFullPathName()
> + " type = " + t.toString() + " quota = "
> + typeQuota + " < consumed " + typeSpace);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
