[ 
https://issues.apache.org/jira/browse/HDFS-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhe Zhang updated HDFS-7729:
----------------------------
    Attachment: HDFS-7729-007.patch

Thanks Bo for the rev! Great work and I think we are almost there.

I made a pass and refactored {{writeChunk}}. Basically I think we should finish 
the regular packet enqueuing operation, and then handle parity data. Let me 
know how it looks to you. A few other questions:

# Why do we need {{hasSentEndPacket}}?
# {{TestFileAppend}} fails with 006 patch. In 007 patch I moved 2 lines in the 
append constructor and most of the test class passed. {{testCopyOnWrite}} is 
still failing. Can you take a look? I think it might be related to 
{{hasSentEndPacket}}
# {{generatePackets}} needs Javadoc. It's easy to miss that it also does 
{{incBytesCurBlock}} to the current streamer
# Let's split out flush support. In this patch we can simply return IOException 
when flush is called on striped files.

> Add logic to DFSOutputStream to support writing a file in striping layout 
> --------------------------------------------------------------------------
>
>                 Key: HDFS-7729
>                 URL: https://issues.apache.org/jira/browse/HDFS-7729
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Li Bo
>         Attachments: Codec-tmp.patch, HDFS-7729-001.patch, 
> HDFS-7729-002.patch, HDFS-7729-003.patch, HDFS-7729-004.patch, 
> HDFS-7729-005.patch, HDFS-7729-006.patch, HDFS-7729-007.patch
>
>
> If client wants to directly write a file striping layout, we need to add some 
> logic to DFSOutputStream.  DFSOutputStream needs multiple DataStreamers to 
> write each cell of a stripe to a remote datanode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to