[ 
https://issues.apache.org/jira/browse/HDFS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333100#comment-14333100
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7397:
-------------------------------------------

> I am ok with this..( But here we are missing "cache", since connections will 
> be cached)..

I see.  How about dfs.client.read.shortcircuit.cache.block-count-max?  The word 
"block" seems better than "stream".

> Why not just add some text to the description in hdfs-default.xml?

Do you agree that "dfs.client.read.shortcircuit.streams.cache.size" is 
misleading?

> The conf key "dfs.client.read.shortcircuit.streams.cache.size" is misleading
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-7397
>                 URL: https://issues.apache.org/jira/browse/HDFS-7397
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>
> For dfs.client.read.shortcircuit.streams.cache.size, is it in MB or KB?  
> Interestingly, it is neither in MB nor KB.  It is the number of shortcircuit 
> streams.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to