[ 
https://issues.apache.org/jira/browse/HDFS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334270#comment-14334270
 ] 

Colin Patrick McCabe commented on HDFS-7397:
--------------------------------------------

bq. dfs.client.read.shortcircuit.cache.block-count-max?

We're not caching blocks, we're caching file descriptors.

bq. Do you agree that "dfs.client.read.shortcircuit.streams.cache.size" is 
misleading?

To be honest, I think the current name is fine.  This is a cache of file 
descriptors.  You can't cache half a file descriptor, hence questions like "is 
it in kb or mb" have no meaning.  That is why I suggested updating the docs.  I 
do not feel strongly about it, though.

> The conf key "dfs.client.read.shortcircuit.streams.cache.size" is misleading
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-7397
>                 URL: https://issues.apache.org/jira/browse/HDFS-7397
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>
> For dfs.client.read.shortcircuit.streams.cache.size, is it in MB or KB?  
> Interestingly, it is neither in MB nor KB.  It is the number of shortcircuit 
> streams.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to