[ 
https://issues.apache.org/jira/browse/HDFS-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359854#comment-14359854
 ] 

Yi Liu commented on HDFS-7926:
------------------------------

Hi Nicholas, the patch is not for this JIRA, can you check? Thanks.

{quote}
# change ClientProtocol.truncate to @AtMostOnce; or
# change NameNode implementation of ClientProtocol.truncate(..) to idempotent.
{quote}
Currently ClientProtocol#{{append}}, {{create}} use @AtMostOnce, I think it's 
better to use @AtMostOnce for {{truncate}} too.  For #1, we also only need to 
do few change (add the RetryCache). 

> NameNode implementation of ClientProtocol.truncate(..) is not idempotent
> ------------------------------------------------------------------------
>
>                 Key: HDFS-7926
>                 URL: https://issues.apache.org/jira/browse/HDFS-7926
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h7926_20150313.patch
>
>
> If dfsclient drops the first response of a truncate RPC call, the retry by 
> retry cache will fail with "DFSClient ... is already the current lease 
> holder".  The truncate RPC is annotated as @Idempotent in ClientProtocol but 
> the NameNode implementation is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to