[
https://issues.apache.org/jira/browse/HDFS-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360008#comment-14360008
]
Tsz Wo Nicholas Sze commented on HDFS-7926:
-------------------------------------------
> ..., the patch is not for this JIRA, can you check? ...
No the file is for this JIRA. Could you take a look again?
> Currently ClientProtocol#append, create use @AtMostOnce, I think it's better
> to use @AtMostOnce for truncate too. ...
Why truncate has to be the same as append and create? Semantically, truncate
is idempotent, i.e. the result of truncate more than one times is the same as a
truncate.
> NameNode implementation of ClientProtocol.truncate(..) is not idempotent
> ------------------------------------------------------------------------
>
> Key: HDFS-7926
> URL: https://issues.apache.org/jira/browse/HDFS-7926
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h7926_20150313.patch
>
>
> If dfsclient drops the first response of a truncate RPC call, the retry by
> retry cache will fail with "DFSClient ... is already the current lease
> holder". The truncate RPC is annotated as @Idempotent in ClientProtocol but
> the NameNode implementation is not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
