[
https://issues.apache.org/jira/browse/HDFS-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384934#comment-14384934
]
Zhe Zhang commented on HDFS-8005:
---------------------------------
Thanks for the patch Jing!
bq. Instead of recording missing block indies, we can directly capture the
live/healthy block indies. This can simplify both the NN side computation and
later the DN side interpretation.
I think this is a valid simplification. The only concern is that the DN won't
have the logic to prefer {{DECOMMISSION_INPROGRESS}} nodes.
bq. The test also provides a utility function that can create a file with
striped blocks by using synthetic block reports.
Great! Maybe the input stream test can leverage this utility function too.
Sorry I didn't notice a patch was uploaded for HDFS-7907. Will review that one
first.
> Erasure Coding: simplify striped block recovery work computation and add tests
> ------------------------------------------------------------------------------
>
> Key: HDFS-8005
> URL: https://issues.apache.org/jira/browse/HDFS-8005
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8005.000.patch, HDFS-8005.000.patch
>
>
> HDFS-7369 adds the functionality to distribute recovery work of striped
> blocks to datanodes. There are still some pending issues:
> # In {{BlockManager#chooseSourceNode}}, a node is added into
> {{healthyIndices}} without checking if its block is live and healthy
> # The test {{TestRecoverStripedBlcoks#testMissingStripedBlock}} has not
> tested striped blocks because the file is created before setting the storage
> policy
> # In {{computeRecoveryWorkForBlocks}}, instead of using
> {{BlockCollection#isStriped}}, we'd better use {{BlockInfo#isStriped}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
