[
https://issues.apache.org/jira/browse/HDFS-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484895#comment-14484895
]
Uma Maheswara Rao G commented on HDFS-8074:
-------------------------------------------
ECSchemaManager should load defaults from xml right. I think right now it is
not loading from XML and it is simply holding ECSchema object by passing local
defaults. Did I miss something?
Please have braces for if conditions.
{code}
if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+
+ ECSchema ecSchema = (ECSchema) o;
+
+ if (numDataUnits != ecSchema.numDataUnits) return false;
+ if (numParityUnits != ecSchema.numParityUnits) return false;
+ if (chunkSize != ecSchema.chunkSize) return false;
+ if (!schemaName.equals(ecSchema.schemaName)) return false;
+ if (!codecName.equals(ecSchema.codecName)) return false;
{code}
> Define a system-wide default EC schema
> --------------------------------------
>
> Key: HDFS-8074
> URL: https://issues.apache.org/jira/browse/HDFS-8074
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8074-v1.patch, HDFS-8074-v2.patch
>
>
> It's good to have a system default EC schema first with fixed values before
> we support more schemas. This makes sense to resolve some dependencies before
> HDFS-7866 can be done in whole. The default system schema is also needed
> anyhow essentially when admin just wants to use it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
