[
https://issues.apache.org/jira/browse/HDFS-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486784#comment-14486784
]
Kai Zheng commented on HDFS-8062:
---------------------------------
The change looks great. Comments so far:
1. Is it possible to use the default ECSchema object itself in
{{DFSStripedInputStream}} as it will use a schema particularly coming to
recover erased block data?
2. Better to mention the JIRA (HDFS-7866) in the related TODOs;
3. Please use {{ECSchema#getNumTotalUnits}} when possible since you added it;
4. Could we have a TODO in {{BlockInfoStriped#write}}? It should persist the
schema object itself I guess.
5. In the following, I guess we should always need and use a passed schema
object, instead of the default one here. Please also check other places. I
thought we should limit the places to use the default schema, as it might be
only used in higher entries where dynamic schema object will be used to replace
it later.
{code}
+ public BlockInfoStripedUnderConstruction(Block blk) {
+ this(blk, ECSchemaManager.getSystemDefaultSchema());
+ }
{code}
6. {{TestReadStripedFile}} is refactored in HDFS-8104, we could remote the
change for it here.
> Remove hard-coded values in favor of EC schema
> ----------------------------------------------
>
> Key: HDFS-8062
> URL: https://issues.apache.org/jira/browse/HDFS-8062
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Sasaki
> Attachments: HDFS-8062.1.patch, HDFS-8062.2.patch
>
>
> Related issues about EC schema in NameNode side:
> HDFS-7859 is to change fsimage and editlog in NameNode to persist EC schemas;
> HDFS-7866 is to manage EC schemas in NameNode, loading, syncing between
> persisted ones in image and predefined ones in XML.
> This is to revisit all the places in NameNode that uses hard-coded values in
> favor of {{ECSchema}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
