[
https://issues.apache.org/jira/browse/HDFS-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493222#comment-14493222
]
Kai Zheng commented on HDFS-8062:
---------------------------------
Some comments:
1. A typo in {{DFSStripedInputStream}}.
{code}
+ private ECSchema schame;
{code}
2. I thought it should be HDFS-7859. Sorry if I misguided you.
{code}
+ // TODO: ECSchema should in included in p: StripedBlockProto. (HDFS-7866)
{code}
3. In client side in {{DFSStripedOutputStream}}, ref. the below change, we see
no benefit doing this since they're essentially the same. This issue would be
better to focus on using an EC schema object itself in relevant places, and the
system default schema should only be used in EC zone creation while no schema
is specified.
{code}
- private final short blockGroupBlocks = HdfsConstants.NUM_DATA_BLOCKS
- + HdfsConstants.NUM_PARITY_BLOCKS;
- private final short blockGroupDataBlocks = HdfsConstants.NUM_DATA_BLOCKS;
+ private final short blockGroupBlocks
+ = (short) ECSchemaManager.getSystemDefaultSchema().getNumTotalUnits();
+ private final short blockGroupDataBlocks
+ = (short)ECSchemaManager.getSystemDefaultSchema().getNumDataUnits();
{code}
As part of this issue, HDFS-8136 was opened to address the client side for
this. [~kaisasak], would you work on it first? We could resolve this some time
later when other deps are resolved first.
> Remove hard-coded values in favor of EC schema
> ----------------------------------------------
>
> Key: HDFS-8062
> URL: https://issues.apache.org/jira/browse/HDFS-8062
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Sasaki
> Attachments: HDFS-8062.1.patch, HDFS-8062.2.patch, HDFS-8062.3.patch
>
>
> Related issues about EC schema in NameNode side:
> HDFS-7859 is to change fsimage and editlog in NameNode to persist EC schemas;
> HDFS-7866 is to manage EC schemas in NameNode, loading, syncing between
> persisted ones in image and predefined ones in XML.
> This is to revisit all the places in NameNode that uses hard-coded values in
> favor of {{ECSchema}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
