[
https://issues.apache.org/jira/browse/HDFS-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495702#comment-14495702
]
Vinayakumar B commented on HDFS-8123:
-------------------------------------
Patch looks good.
Just one nit.
Remove unused import in ClientNamenodeProtocolTranslatorPB.java
{code}import
org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.CreateErasureCodingZoneResponseProto;{code}
+1 after that.
> Erasure Coding: Better to move EC related proto messages to a separate
> erasurecoding proto file
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-8123
> URL: https://issues.apache.org/jira/browse/HDFS-8123
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-8123-001.patch, HDFS-8123-002.patch,
> HDFS-8123-003.patch, HDFS-8123-004.patch
>
>
> While reviewing the code I've noticed EC related proto messages are getting
> added into {{hdfs.proto}}. IMHO, for better maintainability of the erasure
> code feature, its good to move this to a separate {{erasurecode.proto}} file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
