[
https://issues.apache.org/jira/browse/HDFS-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498465#comment-14498465
]
Zhe Zhang commented on HDFS-8156:
---------------------------------
Thanks Kai for the patch! The overall logic looks good.
# Sorry that I didn't have a chance to review the initial HADOOP-11643 patch.
{{options}} could use some Javadoc to explain. If {{ECSchema}} is for a single
schema, why do we need a set of options, each containing {{NUM_DATA_UNITS}}
etc.?
# The change in {{ECSchemaManager}} looks clear and fits the JIRA description.
# We should add a test to get schema by name. E.g., we can test a valid name
and a non-existing name.
> Define some system schemas in codes
> -----------------------------------
>
> Key: HDFS-8156
> URL: https://issues.apache.org/jira/browse/HDFS-8156
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8156-v1.patch
>
>
> This is to define and add some system schemas in codes, and also resolve some
> TODOs left for HDFS-7859 and HDFS-7866 as they're still subject to further
> discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
