[
https://issues.apache.org/jira/browse/HDFS-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499161#comment-14499161
]
Xinwei Qin commented on HDFS-8156:
-----------------------------------
Hi, [~drankye]
Does the map field {{options}} of {{ECSchema}} contain {{NUM_DATA_UNITS_KEY}},
{{NUM_PARITY_UNITS_KEY}}, {{CODEC_NAME_KEY}}? In the method {{initWith()}} you
remove them from {{options}}, but in the method {{toString()}} you think them
contained in {{options}}, and try to skip them.
{code}
for (String opt : options.keySet()) {
- boolean skip = (opt.equals(NUM_DATA_UNITS_KEY) ||
+ boolean skip = (opt.equals(CODEC_NAME_KEY) ||
+ opt.equals(NUM_DATA_UNITS_KEY) ||
opt.equals(NUM_PARITY_UNITS_KEY) ||
opt.equals(CHUNK_SIZE_KEY));
{code}
IMO, the {{options}} does not need to contain other fields. Based on this,
change its name to {{extraOptions}} may be better and can avoid confusion, as
the field {{options}} in {{ECSChema}} and the parameter {{options}} of
constructor method {{ECSchema(String schemaName, Map<String, String> options)}}
are two different things. what do you think?.
> Define some system schemas in codes
> -----------------------------------
>
> Key: HDFS-8156
> URL: https://issues.apache.org/jira/browse/HDFS-8156
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8156-v1.patch, HDFS-8156-v2.patch
>
>
> This is to define and add some system schemas in codes, and also resolve some
> TODOs left for HDFS-7859 and HDFS-7866 as they're still subject to further
> discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
