[
https://issues.apache.org/jira/browse/HDFS-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499289#comment-14499289
]
Hadoop QA commented on HDFS-8163:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726045/HDFS-8163.02.patch
against trunk revision 9595cc0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.util.TestByteArrayManager
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10293//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10293//console
This message is automatically generated.
> Using monotonicNow for block report scheduling causes test failures on
> recently restarted systems
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-8163
> URL: https://issues.apache.org/jira/browse/HDFS-8163
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.6.1
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Blocker
> Attachments: HDFS-8163.01.patch, HDFS-8163.02.patch
>
>
> {{BPServiceActor#blockReport}} has the following check:
> {code}
> List<DatanodeCommand> blockReport() throws IOException {
> // send block report if timer has expired.
> final long startTime = monotonicNow();
> if (startTime - lastBlockReport <= dnConf.blockReportInterval) {
> return null;
> }
> {code}
> Many tests trigger an immediate block report via
> {{BPServiceActor#triggerBlockReportForTests}} which sets {{lastBlockReport =
> 0}}. However if the machine was restarted recently then startTime may be less
> than {{dnConf.blockReportInterval}} and the block report is not sent.
> {{Time#monotonicNow}} uses {{System#nanoTime}} which represents time elapsed
> since an arbitrary origin. The time should be used only for comparison with
> other values returned by {{System#nanoTime}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
