[
https://issues.apache.org/jira/browse/HDFS-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505350#comment-14505350
]
Jing Zhao commented on HDFS-8163:
---------------------------------
Thanks for working on this, [~arpitagarwal]! The patch looks pretty good to me.
The only nits is that the following code can be reformatted:
{code}
+ @VisibleForTesting volatile long nextBlockReportTime = monotonicNow();
+ @VisibleForTesting volatile long nextHeartbeatTime = monotonicNow();
+ @VisibleForTesting boolean resetBlockReportTime = true;
{code}
I think you can address this while committing the patch. +1.
> Using monotonicNow for block report scheduling causes test failures on
> recently restarted systems
> -------------------------------------------------------------------------------------------------
>
> Key: HDFS-8163
> URL: https://issues.apache.org/jira/browse/HDFS-8163
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.6.1
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Blocker
> Attachments: HDFS-8163.01.patch, HDFS-8163.02.patch,
> HDFS-8163.03.patch
>
>
> {{BPServiceActor#blockReport}} has the following check:
> {code}
> List<DatanodeCommand> blockReport() throws IOException {
> // send block report if timer has expired.
> final long startTime = monotonicNow();
> if (startTime - lastBlockReport <= dnConf.blockReportInterval) {
> return null;
> }
> {code}
> Many tests trigger an immediate block report via
> {{BPServiceActor#triggerBlockReportForTests}} which sets {{lastBlockReport =
> 0}}. However if the machine was restarted recently then startTime may be less
> than {{dnConf.blockReportInterval}} and the block report is not sent.
> {{Time#monotonicNow}} uses {{System#nanoTime}} which represents time elapsed
> since an arbitrary origin. The time should be used only for comparison with
> other values returned by {{System#nanoTime}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
