[ 
https://issues.apache.org/jira/browse/HDFS-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506719#comment-14506719
 ] 

Kai Sasaki commented on HDFS-8136:
----------------------------------

[~vinayrpet] Thank you for reviewing. I updated some points other below things. 

{quote}
1. cellSize also can be final
{quote}

{{cellSize}} can be set by {{setCellSize}} after initialization. This member 
cannot be final.

{quote}
4. IMO cluster need not recreated for every test. It can be initialized once 
for class and shutdown at the end of all tests.
{quote}

{{MiniDFSCluster}} seems to have to be configured with {{Configuration}} which 
cannot be created in one line. So I think moving this outside {{\@Before}} will 
make code more complex. 


> Client gets and uses EC schema when reads and writes a stripping file
> ---------------------------------------------------------------------
>
>                 Key: HDFS-8136
>                 URL: https://issues.apache.org/jira/browse/HDFS-8136
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Kai Zheng
>            Assignee: Kai Sasaki
>         Attachments: HDFS-8136-005.patch, HDFS-8136.1.patch, 
> HDFS-8136.2.patch, HDFS-8136.3.patch, HDFS-8136.4.patch, HDFS-8136.6.patch
>
>
> Discussed with [~umamaheswararao] and [~vinayrpet], in client when reading 
> and writing a stripping file, it can invoke a separate call to NameNode to 
> request the EC schema associated with the EC zone where the file is in. Then 
> the schema can be used to guide the reading and writing. Currently it uses 
> hard-coded values.
> Optionally, as an optimization consideration, client may cache schema info 
> per file or per zone or per schema name. We could add schema name in 
> {{HdfsFileStatus}} for that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to