[ 
https://issues.apache.org/jira/browse/HDFS-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511401#comment-14511401
 ] 

Jing Zhao commented on HDFS-8235:
---------------------------------

The patch looks good to me overall. Some further optimization that we can do:
# {{getErasureCodingInfo}} is called twice for {{DFSStripedInputStream}}: one 
in {{DFSClient#open}}, the other in {{DFSStripedInputStream}}'s constructor. 
Thus we can change {{DFSStripedInputStream}}'s constructor and pass the ecinfo 
as a parameter.
# With the patch now we can directly use {{FileSystem#open}} in 
{{TestDFSStripedInputStream#testOneFileUsingDFSStripedInputStream}}.

> Create DFSStripedInputStream in DFSClient#open
> ----------------------------------------------
>
>                 Key: HDFS-8235
>                 URL: https://issues.apache.org/jira/browse/HDFS-8235
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Kai Sasaki
>         Attachments: HDFS-8235.1.patch
>
>
> Currently DFSClient#open can only create a DFSInputStream object. It should 
> also support DFSStripedInputStream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to