[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513515#comment-14513515
]
Zhe Zhang commented on HDFS-8255:
---------------------------------
{code}
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
273 274
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
348 349
{code}
I checked those line numbers; these 2 checkstyle issues are not caused by the
patch.
> Rename getBlockReplication to getPreferredBlockStorageNum
> ---------------------------------------------------------
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
