[
https://issues.apache.org/jira/browse/HDFS-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519802#comment-14519802
]
Jing Zhao commented on HDFS-8283:
---------------------------------
Thanks for working on this, Nicholas! The patch looks pretty good to me. The
test failure should be unrelated and it passed in my local run. +1
I will commit the patch shortly.
> DataStreamer cleanup and some minor improvement
> -----------------------------------------------
>
> Key: HDFS-8283
> URL: https://issues.apache.org/jira/browse/HDFS-8283
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: h8283_20150428.patch
>
>
> - When throwing an exception
> -* always set lastException
> -* always creating a new exception so that it has the new stack trace
> - Add LOG.
> - Add final to isAppend and favoredNodes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
