[ 
https://issues.apache.org/jira/browse/HDFS-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521891#comment-14521891
 ] 

Jing Zhao commented on HDFS-8283:
---------------------------------

bq. It seems this patch introduced a findbugs warning. I'm not sure why 
pre-commit didn't catch it.

Thanks for the report, Chris! I just created HDFS-8300 to fix the unit test 
failures and findbugs warning.

> DataStreamer cleanup and some minor improvement
> -----------------------------------------------
>
>                 Key: HDFS-8283
>                 URL: https://issues.apache.org/jira/browse/HDFS-8283
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: h8283_20150428.patch
>
>
> - When throwing an exception
> -* always set lastException 
> -* always creating a new exception so that it has the new stack trace
> - Add LOG.
> - Add final to isAppend and favoredNodes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to