[
https://issues.apache.org/jira/browse/HDFS-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913862#action_12913862
]
Konstantin Shvachko commented on HDFS-1400:
-------------------------------------------
Looks good. Couple of things:
# Did not find any calls to public method BlockReader.getFileName(addr, poolId,
blockId). If this is true could you please remove it for now.
# Do we need to increment DATA_TRANSFER_VERSION if its methods parameters are
changing?
# It is better to make descriptions of methods as javadoc comments.
+1 besides this minor things.
> HDFS federation: Introduce block pool ID into DataTransferProtocol
> ------------------------------------------------------------------
>
> Key: HDFS-1400
> URL: https://issues.apache.org/jira/browse/HDFS-1400
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1400.1.patch, HDFS-1400.patch
>
>
> Block Pool ID needs to be introduced in to DataTransferProtocol
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
