[
https://issues.apache.org/jira/browse/HDFS-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914103#action_12914103
]
Suresh Srinivas commented on HDFS-1400:
---------------------------------------
Thanks for the review, Konstantin.
> Did not find any calls to public method BlockReader.getFileName(addr,
> poolId, blockId).
Removed BlockReader.getFileName(addr, blockid) and calls are made only to
BlockReader.getFileName(addr, poolId, blockId)
> Do we need to increment DATA_TRANSFER_VERSION if its methods parameters are
> changing?
Done
> It is better to make descriptions of methods as javadoc comments.
Added javadoc comments to BlockReader#getFileName()
> HDFS federation: Introduce block pool ID into DataTransferProtocol
> ------------------------------------------------------------------
>
> Key: HDFS-1400
> URL: https://issues.apache.org/jira/browse/HDFS-1400
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: Federation Branch
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: Federation Branch
>
> Attachments: HDFS-1400.1.patch, HDFS-1400.patch
>
>
> Block Pool ID needs to be introduced in to DataTransferProtocol
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
