[
https://issues.apache.org/jira/browse/HDFS-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522760#comment-14522760
]
Zhe Zhang commented on HDFS-7348:
---------------------------------
Please find my full review below. The overall patch looks good to me. Thanks Yi
again for the work!
# _Follow on_: we should consider consolidating the init thread pool logic for
hedged read, client striped read, and DN striped read.
# As mentioned under HDFS-8282, we should probably get rid of the {{getBlock}}
method here.
# How about {{DataRecoveryAndTransfer}} -> {{ReconstructAndTransferBlock}}?
It's not a big deal, but we have decided to use reconstruction for EC to avoid
confusion with block recovery.
# Should {{WRITE_PACKET_SIZE}} be linked to
{{BlockSender#MIN_BUFFER_WITH_TRANSFERTO}}?
# Why do we need {{targetInputStreams}}?
# In the test, the following 2 lines should be flipped:
{code}
cluster.getFileSystem().getClient().createErasureCodingZone("/", null);
fs = cluster.getFileSystem();
{code}
# The test failed on my local machine, reporting NPE when closing file:
{code}
java.io.IOException: java.lang.NullPointerException
at
org.apache.hadoop.hdfs.DataStreamer$LastException.check(DataStreamer.java:193)
at
org.apache.hadoop.hdfs.DFSStripedOutputStream.closeImpl(DFSStripedOutputStream.java:422)
{code}
# {{cluster#stopDataNode}} might be an easier way to kill a DN?
# We could set {{DFS_NAMENODE_REPLICATION_INTERVAL_KEY}} to 1 to speedup the
test
> Erasure Coding: striped block recovery
> --------------------------------------
>
> Key: HDFS-7348
> URL: https://issues.apache.org/jira/browse/HDFS-7348
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Kai Zheng
> Assignee: Yi Liu
> Attachments: ECWorker.java, HDFS-7348.001.patch
>
>
> This JIRA is to recover one or more missed striped block in the striped block
> group.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
