[ 
https://issues.apache.org/jira/browse/HDFS-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533897#comment-14533897
 ] 

Vinayakumar B commented on HDFS-4185:
-------------------------------------

Thanks [~rakeshr] for taking up this issue.

Source changes looks good.
I think current test will just check the API, not the metric via metric system.
It would be better to have a test to verify the metric via metric system. Check 
{{TestNameNodeMetrics}} FYR.

> Add a metric for number of active leases
> ----------------------------------------
>
>                 Key: HDFS-4185
>                 URL: https://issues.apache.org/jira/browse/HDFS-4185
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 0.23.4, 2.0.2-alpha
>            Reporter: Kihwal Lee
>            Assignee: Rakesh R
>              Labels: BB2015-05-RFC
>         Attachments: HDFS-4185-001.patch, HDFS-4185-002.patch, 
> HDFS-4185-003.patch
>
>
> We have seen cases of systematic open file leaks, which could have been 
> detected if we have a metric that shows number of active leases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to