[
https://issues.apache.org/jira/browse/HDFS-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536141#comment-14536141
]
Rakesh R commented on HDFS-4185:
--------------------------------
1. Whitespace warnings are unrelated to this patch.
{code}
./hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md:140:The
DataNode stores HDFS data in files in its local file system. The DataNode has
no knowledge about HDFS files. It stores each block of HDFS data in a separate
file in its local file system. The DataNode does not create all files in the
same directory. Instead, it uses a heuristic to determine the optimal number of
files per directory and creates subdirectories appropriately. It is not
optimal to create all local files in the same directory because the local file
system might not be able to efficiently support a huge number of files in a
single directory. When a DataNode starts up, it scans through its local file
system, generates a list of all HDFS data blocks that correspond to each of
these local files, and sends this report to the NameNode. The report is called
the _Blockreport_.
{code}
2. Checkstyle warnings also unrelated
{code}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:225:32:
'out' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:242:
First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:250:28:
'out' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:89:
First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:523:18:
',' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:524:30:
',' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:250:28:
'out' hides a field.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:89:
First sentence should end with a period.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:523:18:
',' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:524:30:
',' is not followed by whitespace.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1:
File length is 8,302 lines (max allowed is 2,000).
{code}
3. testcase failure also unrelated.
> Add a metric for number of active leases
> ----------------------------------------
>
> Key: HDFS-4185
> URL: https://issues.apache.org/jira/browse/HDFS-4185
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 0.23.4, 2.0.2-alpha
> Reporter: Kihwal Lee
> Assignee: Rakesh R
> Labels: BB2015-05-TBR
> Attachments: HDFS-4185-001.patch, HDFS-4185-002.patch,
> HDFS-4185-003.patch, HDFS-4185-004.patch, HDFS-4185-005.patch
>
>
> We have seen cases of systematic open file leaks, which could have been
> detected if we have a metric that shows number of active leases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
