[ 
https://issues.apache.org/jira/browse/HDFS-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917815#action_12917815
 ] 

Konstantin Boudnik commented on HDFS-1434:
------------------------------------------

Also, please run {{test-patch.sh}} at least locally (Hudson seems to be 
non-working) to make sure, among oher things, that Herriot bindings remain 
intact.

> Refactor Datanode#startDataNode method
> --------------------------------------
>
>                 Key: HDFS-1434
>                 URL: https://issues.apache.org/jira/browse/HDFS-1434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1434.patch
>
>
> This method is very long, approximately 190 lines. Splitting this method into 
> smaller methods. This also helps in federation where some of the 
> initialization in this methods will be done once for a datanode and others 
> once in every heartbeat thread per namenode in DN.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to