[
https://issues.apache.org/jira/browse/HDFS-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917841#action_12917841
]
Suresh Srinivas commented on HDFS-1434:
---------------------------------------
All unit tests passed other than TestComputeInvalidateWork and TestLargeBlock.
These failures are unrelated to this patch.
test-patch output:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests
framework compile.
> Refactor Datanode#startDataNode method
> --------------------------------------
>
> Key: HDFS-1434
> URL: https://issues.apache.org/jira/browse/HDFS-1434
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: HDFS-1434.patch
>
>
> This method is very long, approximately 190 lines. Splitting this method into
> smaller methods. This also helps in federation where some of the
> initialization in this methods will be done once for a datanode and others
> once in every heartbeat thread per namenode in DN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
