[
https://issues.apache.org/jira/browse/HDFS-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537535#comment-14537535
]
Takanobu Asanuma commented on HDFS-7687:
----------------------------------------
Additional comments for HDFS-7687.2.patch:
# I created {{NamenodeFsck.ECResult}} like {{NamenodeFsck.Result}}.
{{NamenodeFsck.ECResult}} is for EC, and {{NAmenodeFsck.Result}} is for
replication.
# {{totalDir}} and {{totalSimlik}} are common variables between EC and
replication in result, so I moved them to the local variables of
{{NamenodeFsck}}.
# I renamed {{collectFileSummary}} to {{collectReplicatedFileSummary}}, and
{{collectBlockSummary}} to {{collectReplicatedBlockSummary}}. I just renamed
methods here. So if there are some changes in trunk, they will be merged easyly.
# I use EC terminologies in some places instead of replication terminologies
like following:
## ReplicatedBlock(s) -> BlockGroup(s)
## Replica(s) -> InternalBlock(s)
## totalReplicasPerBlock -> totalInternalBlocksPerGroup
# I have a concern that these are fairly large changes in output. Should we
mark it as incompatible?
Please review my patch and see my concern. If there is no problem, I will add
more unit tests. Thank you.
> Change fsck to support EC files
> -------------------------------
>
> Key: HDFS-7687
> URL: https://issues.apache.org/jira/browse/HDFS-7687
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Takanobu Asanuma
> Attachments: HDFS-7687.1.patch, HDFS-7687.2.patch
>
>
> We need to change fsck so that it can detect "under replicated" and corrupted
> EC files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
