[ 
https://issues.apache.org/jira/browse/HDFS-7687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539187#comment-14539187
 ] 

Tsz Wo Nicholas Sze commented on HDFS-7687:
-------------------------------------------

- ECResult and Result have a lot of duplication.  Let's create a base class, 
say AbstractResult and move the shared code to their.
- Similarly, collectECBlockGroupsSummary/collectECFileSummary and 
collectReplicatedBlocksSummary/collectReplicatedFileSummary also has 
duplication.  Let's create some methods to share the code.
- Tried to run TestFsck but it fails with NullPointerException as shown below.  
Could you take a look?  It seems that there is a bug in computing quota for ec 
files.  If it is the case, could you file a JIRA?
{code}
Tests run: 23, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 68.833 sec <<< 
FAILURE! - in org.apache.hadoop.hdfs.server.namenode.TestFsck
testECFsck(org.apache.hadoop.hdfs.server.namenode.TestFsck)  Time elapsed: 
1.912 sec  <<< ERROR!
java.lang.NullPointerException: null
        at 
org.apache.hadoop.hdfs.server.namenode.QuotaCounts.add(QuotaCounts.java:82)
        at 
org.apache.hadoop.hdfs.server.namenode.INodeFile.computeQuotaUsage(INodeFile.java:665)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.updateCountForQuotaRecursively(FSImage.java:885)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.updateCountForQuotaRecursively(FSImage.java:881)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.updateCountForQuota(FSImage.java:866)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.loadEdits(FSImage.java:849)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:692)
        at 
org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:294)
        at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:996)
        at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:702)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:584)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:644)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:809)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:793)
        at 
org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1481)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:1114)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:985)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:814)
        at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:471)
        at 
org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:430)
        at 
org.apache.hadoop.hdfs.server.namenode.TestFsck.testECFsck(TestFsck.java:1673)
{code}

> Change fsck to support EC files
> -------------------------------
>
>                 Key: HDFS-7687
>                 URL: https://issues.apache.org/jira/browse/HDFS-7687
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Takanobu Asanuma
>         Attachments: HDFS-7687.1.patch, HDFS-7687.2.patch
>
>
> We need to change fsck so that it can detect "under replicated" and corrupted 
> EC files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to