[
https://issues.apache.org/jira/browse/HDFS-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540711#comment-14540711
]
Zhe Zhang commented on HDFS-8186:
---------------------------------
Thanks Walter for the work. The patch looks good to me overall. A few issues I
can see:
# {{BlockPlacementPolicy#getInstance}} is still used at 2 places: {{Balancer}}
and {{NamenodeFsck}}. Should we address these 2 usages in this patch? If not,
will {{NamenodeFsck}} work correctly?
# Minor issue, the below method is not needed:
{code}
+ BlockPlacementPolicy getDefaultPolicy(){
+ return replicationPolicy;
+ }
{code}
# These 2 can be final:
{code}
+ private BlockPlacementPolicy replicationPolicy;
+ private BlockPlacementPolicy ecPolicy;
{code}
# We can add a simple test
> Erasure coding: Make block placement policy for EC file configurable
> --------------------------------------------------------------------
>
> Key: HDFS-8186
> URL: https://issues.apache.org/jira/browse/HDFS-8186
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HDFS-8186.001.patch
>
>
> This includes:
> 1. User can config block placement policy for EC file in xml configuration
> file.
> 2. EC policy works for EC file, replication policy works for non-EC file.
> They are coexistent.
> Not includes:
> 1. Details of block placement policy for EC. Discussion and implementation
> goes to HDFS-7613.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
