[
https://issues.apache.org/jira/browse/HDFS-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540859#comment-14540859
]
Xiaoyu Yao commented on HDFS-8345:
----------------------------------
The patch looks good to me. I just have few comments:
1. NIT: Missing "@throws IOException" for Javadoc of
FileSystem#setStoragePolicy().
2. Do we miss the ViewFS#getStoragePolicyNames() override since
ViewFS#setStoragePolicy is override. Or we expect it fallback to
FileSystem#getStoragePoliciyNames that throws UnsupportedOperationException?
3. Can you add a unit test for the new API getStoragePolicyNames()?
> Storage policy APIs must be exposed via the FileSystem interface
> ----------------------------------------------------------------
>
> Key: HDFS-8345
> URL: https://issues.apache.org/jira/browse/HDFS-8345
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.7.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Labels: BB2015-05-TBR
> Attachments: HDFS-8345.01.patch
>
>
> The storage policy APIs are not exposed via FileSystem. Since
> DistributedFileSystem is tagged as LimitedPrivate we should expose the APIs
> through FileSystem for use by other applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
