[ 
https://issues.apache.org/jira/browse/HDFS-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541080#comment-14541080
 ] 

Jing Zhao commented on HDFS-8345:
---------------------------------

Thanks for working on this, Arpit! The patch looks good to me overall. My only 
concern is that only exposing {{setStoragePolicy}} and 
{{getStoragePoliciyNames}} may be incomplete, since the user will only know the 
names of the policies. Since {{StorageType}} is already in 
{{org.apache.hadoop.fs}}, how about also moving {{BlockStoragePolicy}} into 
{{org.apache.hadoop.fs}} and expose it as public? Then we can expose both 
{{setStoragePolicy}} and {{getStoragePolicies}} in {{FileSystem}}.

> Storage policy APIs must be exposed via the FileSystem interface
> ----------------------------------------------------------------
>
>                 Key: HDFS-8345
>                 URL: https://issues.apache.org/jira/browse/HDFS-8345
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-8345.01.patch, HDFS-8345.02.patch
>
>
> The storage policy APIs are not exposed via FileSystem. Since 
> DistributedFileSystem is tagged as LimitedPrivate we should expose the APIs 
> through FileSystem for use by other applications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to