[
https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543483#comment-14543483
]
Rakesh R commented on HDFS-8294:
--------------------------------
Latest patch addressing the review comments. Recently it got introduced a new
FindBug warning in {{StripedBlockUtil}} class, I've included this also in my
patch.
+FindBug warning:-+
{code}
Dead store to dataBlkNum in
org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int,
StripedBlockUtil$AlignedStripe[])
Bug type DLS_DEAD_LOCAL_STORE (click for details)
In class org.apache.hadoop.hdfs.util.StripedBlockUtil
In method
org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int,
StripedBlockUtil$AlignedStripe[])
Local variable named dataBlkNum
At StripedBlockUtil.java:[line 467]
{code}
+Note:+ "Inconsistent synchronization of
org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked 88% of time" FindBug
warning will be resolved once HDFS-8386 is committed to trunk.
> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
> Key: HDFS-8294
> URL: https://issues.apache.org/jira/browse/HDFS-8294
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: BB2015-05-RFC
> Attachments: FindBugs Report in EC feature.html,
> HDFS-8294-HDFS-7285.00.patch, HDFS-8294-HDFS-7285.01.patch,
> HDFS-8294-HDFS-7285.02.patch, HDFS-8294-HDFS-7285.03.patch,
> HDFS-8294-HDFS-7285.04.patch, HDFS-8294-HDFS-7285.05.patch
>
>
> This jira is to address the findbug issues reported in erasure coding feature.
> Attached sheet which contains the details of the findbug issues reported in
> the erasure coding feature. I've taken this report from the jenkins build :
> https://builds.apache.org/job/PreCommit-HDFS-Build/10848/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
