[
https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540788#comment-14540788
]
Zhe Zhang commented on HDFS-8294:
---------------------------------
Thanks for taking care of this Rakesh! It's great to improve code quality in
the HDFS-7285 branch.
Please see if you want to separate out the {{getStreamer()}} refactor to trunk.
{code}
if (replicas == null || replicas.length == 0) {
NameNode.blockStateChangeLog.warn("BLOCK*" +
" BlockInfoStripedUnderConstruction.initLeaseRecovery:" +
" No blocks found, lease removed.");
// sets primary node index and return.
primaryNodeIndex = -1;
return;
}
{code}
Looks good to me.
bq. Maybe we could declare cellSize as long in offsetInBlkToOffsetInBG to avoid
the cast in it?
Well, we don't wait the caller to mistakenly pass in a real long value. This
findbugs warning itself doesn't make much sense to me. BTW, the changed code is
in {{planReadPortions}} instead of {{offsetInBlkToOffsetInBG}}. I'm fine with
how the current patch handles it. In general I feel we should make a pass in
how we handle long and int types in striping logic (in particular,
{{StripedBlockUtil}}. [~rakeshr] do you want to take the lead given the related
work on this JIRA?
I'm +1 once the above are addressed.
> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
> Key: HDFS-8294
> URL: https://issues.apache.org/jira/browse/HDFS-8294
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: BB2015-05-RFC
> Attachments: FindBugs Report in EC feature.html,
> HDFS-8294-HDFS-7285.00.patch, HDFS-8294-HDFS-7285.01.patch,
> HDFS-8294-HDFS-7285.02.patch, HDFS-8294-HDFS-7285.03.patch
>
>
> This jira is to address the findbug issues reported in erasure coding feature.
> Attached sheet which contains the details of the findbug issues reported in
> the erasure coding feature. I've taken this report from the jenkins build :
> https://builds.apache.org/job/PreCommit-HDFS-Build/10848/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
