[ 
https://issues.apache.org/jira/browse/HDFS-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561991#comment-14561991
 ] 

Chris Nauroth commented on HDFS-8431:
-------------------------------------

Hi Anu.  This looks good, and I can help test it.

I have one minor nitpick.  hdfs.cmd is much like the hdfs bash script on 
branch-2.  (The cmd scripts haven't implemented the bash rewrite that was done 
on trunk.)  I'd like to try to keep the cmd scripts as similar as possible to 
the branch-2 bash scripts.  For consistency in the usage output, let's please 
move {{crypto}} after {{cacheadmin}}.  That's how the commands are ordered in 
the bash script's usage message:

https://github.com/apache/hadoop/blob/branch-2/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs#L68

It looks like some other inconsistencies in the ordering have crept in, but 
don't worry about fixing those within the scope of this issue.  We can just 
make sure the addition of {{crypto}} doesn't introduce a new inconsistency.  :-)

Thanks!

> hdfs crypto class not found in Windows
> --------------------------------------
>
>                 Key: HDFS-8431
>                 URL: https://issues.apache.org/jira/browse/HDFS-8431
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: HDFS
>    Affects Versions: 2.6.0
>         Environment: Windows only
>            Reporter: Sumana Sathish
>            Assignee: Anu Engineer
>            Priority: Critical
>              Labels: encryption, windows
>         Attachments: Screen Shot 2015-05-18 at 6.27.11 PM.png, 
> hdfs-8431.001.patch
>
>
> Attached screenshot shows that hdfs could not find class 'crypto' for Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to