[ 
https://issues.apache.org/jira/browse/HDFS-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569666#comment-14569666
 ] 

Zhe Zhang commented on HDFS-8517:
---------------------------------

Thanks Kai for the work. So basically we need to put parity chunks before data 
chunks when decoding, is that right?

If so, the {{convertIndex4Decode}} change looks good except that we could think 
of a better name for {{convertDecodeIndexBack}}.

I think we discussed this before, but could you remind me why we need put 
parity data first?

> Fix a decoding issue in stripped block recovering in client side
> ----------------------------------------------------------------
>
>                 Key: HDFS-8517
>                 URL: https://issues.apache.org/jira/browse/HDFS-8517
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-8517-HDFS-7285-v1.patch
>
>
> [~jingzhao] reported a decoding issue in HDFS-8481 in the comment copied 
> below:
> bq. While debugging HDFS-8319, I just found that in 
> TestWriteReadStripedFile#testWritePreadWithDNFailure, if we change the 
> startOffsetInFile from cellSize * 5 to 0, the test fails with the following 
> error msg:
> {noformat}
> java.lang.AssertionError: Byte at 524288 should be the same expected:<27> but 
> was:<-9>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at 
> org.apache.hadoop.hdfs.TestWriteReadStripedFile.testWritePreadWithDNFailure(TestWriteReadStripedFile.java:390)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to