[
https://issues.apache.org/jira/browse/HDFS-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569798#comment-14569798
]
Jing Zhao commented on HDFS-8517:
---------------------------------
Thanks for the fix, Kai! The patch looks good to me. Just several minors:
# We do not need to create another byte[][] for the reorder: only need to bring
in the index recalculation when putting data into the decodeInputs.
# We need extra work to remove the {{i <= dataBlkNum}} workaround. Specifically
when hitting the first missing chunk, we should start reading all the data
chunks that are out of the reading range, along with a single parity chunk.
Then later each time we hit a missing chunk we read one more parity chunk. I've
already done this fix in HDFS-8319, thus maybe we do not need to include the
fix in this jira.
{code}
- if (chunk.state == StripingChunk.REQUESTED && i <= dataBlkNum) {
+ if (chunk.state == StripingChunk.REQUESTED) {
{code}
> Fix a decoding issue in stripped block recovering in client side
> ----------------------------------------------------------------
>
> Key: HDFS-8517
> URL: https://issues.apache.org/jira/browse/HDFS-8517
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8517-HDFS-7285-v1.patch
>
>
> [~jingzhao] reported a decoding issue in HDFS-8481 in the comment copied
> below:
> bq. While debugging HDFS-8319, I just found that in
> TestWriteReadStripedFile#testWritePreadWithDNFailure, if we change the
> startOffsetInFile from cellSize * 5 to 0, the test fails with the following
> error msg:
> {noformat}
> java.lang.AssertionError: Byte at 524288 should be the same expected:<27> but
> was:<-9>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at
> org.apache.hadoop.hdfs.TestWriteReadStripedFile.testWritePreadWithDNFailure(TestWriteReadStripedFile.java:390)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
