[ 
https://issues.apache.org/jira/browse/HDFS-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570544#comment-14570544
 ] 

Vinayakumar B commented on HDFS-8494:
-------------------------------------

I didnt review the patch fully, but based on discussion with [~drankye],
I think {{BlockInfoStriped#spaceConsumed()}} is not called while loading from 
fsimage, instead it might be called while loading edits. But at this time, we 
can get the zone.

One thing I got at the first look of the patch,
as mentioned in description, why ecZone itself not passed instead of ecschema 
during initialization of patch?
I think this would make things clear. No need to worry about whether zone 
information available during image loading or edits loading to know the cellSize

> Remove hard-coded chunk size in favor of ECZone
> -----------------------------------------------
>
>                 Key: HDFS-8494
>                 URL: https://issues.apache.org/jira/browse/HDFS-8494
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Kai Sasaki
>            Assignee: Kai Sasaki
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-8494-HDFS-7285-01.patch
>
>
> It is necessary to remove hard-coded values inside NameNode configured in 
> {{HdfsConstants}}. In this JIRA, we can remove {{chunkSize}} gracefully in 
> favor of HDFS-8375.
> Because {{cellSize}} is now originally stored only in {{ErasureCodingZone}}, 
> {{BlockInfoStriped}} can receive {{ErasureCodingZone}} instead of 
> {{ECSchema}} when its initialization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to