[ 
https://issues.apache.org/jira/browse/HDFS-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584241#comment-14584241
 ] 

Haohui Mai commented on HDFS-8493:
----------------------------------

Thanks for the work. There are a couple high-level comments here:

1. Safemode related code should reside in {{FSNamesystem}} instead of 
{{FSDirTruncateOp.truncate()}}. 
2. The blocks should be deleted in {{FSNamesystem}} instead of 
{{FSDirTruncateOp.truncate()}}.
3. Most of the functions in {{FSDirTruncateOp}} should be private instead of 
package local.

> Consolidate truncate() related implementation in a single class
> ---------------------------------------------------------------
>
>                 Key: HDFS-8493
>                 URL: https://issues.apache.org/jira/browse/HDFS-8493
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Rakesh R
>         Attachments: HDFS-8493-001.patch, HDFS-8493-002.patch, 
> HDFS-8493-003.patch, HDFS-8493-004.patch
>
>
> This jira proposes to consolidate truncate() related methods into a single 
> class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to