[jira] [Commented] (HDFS-8493) Consolidate truncate() related implementation in a single class

[Rakesh R (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589359#comment-14589359
 ] 

Rakesh R commented on HDFS-8493:
--------------------------------

Thanks [~wheat9] for the reviews. Could you please give few clarifications on 
the below comment.
{quote}
String src = fsd.resolvePath(pc, srcArg, pathComponents);
The resolution should be in the lock of FSDirectory.
{quote}

Will it be OK to acquire {{fsd#readLock}} like below ?
{code}
    final String src;
    final INodesInPath iip;
    fsd.readLock();
    try {
      src = fsd.resolvePath(pc, srcArg, pathComponents);
      iip = fsd.getINodesInPath4Write(src, true);
    } finally {
      fsd.readUnlock();
    }
{code}

> Consolidate truncate() related implementation in a single class
> ---------------------------------------------------------------
>
>                 Key: HDFS-8493
>                 URL: https://issues.apache.org/jira/browse/HDFS-8493
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haohui Mai
>            Assignee: Rakesh R
>         Attachments: HDFS-8493-001.patch, HDFS-8493-002.patch, 
> HDFS-8493-003.patch, HDFS-8493-004.patch, HDFS-8493-005.patch, 
> HDFS-8493-006.patch
>
>
> This jira proposes to consolidate truncate() related methods into a single 
> class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)