[ 
https://issues.apache.org/jira/browse/HDFS-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589326#comment-14589326
 ] 

Arpit Agarwal commented on HDFS-8614:
-------------------------------------

Hi [~anu], thanks for splitting up the patch. :-) A few comments:
# Header.java: Is there a way to reference the {{StorageType}} enumeration 
instead of redefining the strings here so we don't have to worry about keeping 
them in sync. Or we could just skip these definitions for now since we are 
unlikely to support storage types for Ozone soon.
# OzoneQuota.java: {{parseQuota}} - why don't we support quotas given as a raw 
byte count?
# OzoneQuota.java: Nitpick: _Parses an User_ -> _Parses a User_
# OzoneQuota.java: Nitpick: _Supported values are MB,GB_ -> missing space after 
comma.

> OzoneHandler : Add Quota Support 
> ---------------------------------
>
>                 Key: HDFS-8614
>                 URL: https://issues.apache.org/jira/browse/HDFS-8614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: HDFS
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: hdfs-8614-hdfs-7240.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to