[ 
https://issues.apache.org/jira/browse/HDFS-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589351#comment-14589351
 ] 

Anu Engineer commented on HDFS-8614:
------------------------------------

Thanks for the review and comments 

bq.  Header.java: Is there a way to reference the StorageType enumeration 
instead of redefining the strings here so we don't have to worry about keeping 
them in sync. Or we could just skip these definitions for now since we are 
unlikely to support storage types for Ozone soon.

Rationale of Header.java is to keep all strings that are used in the HTTP/REST 
protocol in one place. I have modified the patch to point to the StorageType 
Enum and read from fs.storageType directly. As you said we may not use this 
immediately, but it gives a better definition to the protocol.


bq. OzoneQuota.java: parseQuota - why don't we support quotas given as a raw 
byte count?
I can add that as a feature if you think it is useful. Given that we deal with 
such large volumes of data, I did not think it made much sense to go below MB. 
I will make that change in the next patch.

> OzoneHandler : Add Quota Support 
> ---------------------------------
>
>                 Key: HDFS-8614
>                 URL: https://issues.apache.org/jira/browse/HDFS-8614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: HDFS
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: hdfs-8614-hdfs-7240.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to