[ 
https://issues.apache.org/jira/browse/HDFS-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-8681:
--------------------------------
    Attachment: HDFS-8681.02.patch

v2 patch attempts to retain compatibility with the quirks of the old behavior. 
If the value is not configured or set to <= 0, then fallback to 3 weeks. I've 
changed the default in DFSConfigKeys from 0 to 3 weeks, so we don't use the 
internal 'magic' value DEFAULT_SCAN_PERIOD_HOURS.

I'd appreciate a careful review since this is close to 2.7.1 release. :)

> BlockScanner is incorrectly disabled by default
> -----------------------------------------------
>
>                 Key: HDFS-8681
>                 URL: https://issues.apache.org/jira/browse/HDFS-8681
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Andrew Wang
>            Assignee: Colin Patrick McCabe
>            Priority: Blocker
>         Attachments: HDFS-8681.01.patch, HDFS-8681.02.patch
>
>
> This code is used to check whether the block scanner is enabled:
> {noformat}
>   public boolean isEnabled() {
>     return (conf.scanPeriodMs) > 0 && (conf.targetBytesPerSec > 0);
>   }
> {noformat}
> Unfortunately, when this was introduced, we did not change the default scan 
> period's value of 0, which means by default the BlockScanner is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to